Review Request 124246: Improve sticky notes

[Heiko Tietze]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124246/#review82080
-----------------------------------------------------------


Didn't test the workflow so just about the screenshot. Alignment looks somewhat strange. According https://techbase.kde.org/Projects/Usability/HIG/Alignment the right position is left for the longest label and all other to its right edge. Furthermore the checkbox as introduction to the function is weird. If non-custom means black you could simply omit the checkbox. Probably you adjust b/w in respect to the background. Hence the color would rather fit an indented child below the checkbox. I wonder why font size and color can be set but no other option. Either it's too much (who needs to set color to green or change the default font) or not enough (why not have comic font).

- Heiko Tietze


On Juli 4, 2015, 11:43 vorm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124246/
> -----------------------------------------------------------
> 
> (Updated Juli 4, 2015, 11:43 vorm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> This patch adds the following improvements to the sticky notes applet:
> 
> - A config dialog with previews of the individual colors, the ability to change the font size, and font color - are there any other important options the 4.x one had?
> 
> - Ctrl+Mousewheel to change font size, I always used this "feature" in 4.x and was disappointed that it would not actually save the font size
> 
> - Focus the input field when expanding the applet (eg. when it is in a panel, click the note, start typing)
> 
> - Drag and drop support so you can now drag files and text snippets into the sticky note
> 
> - Better keyboard navigation: you can now place a sticky note in your panel, assign a shortcut to it, press it, note down your thoughts, and close the note again
> 
> 
> Diffs
> -----
> 
>   applets/notes/package/contents/config/config.qml PRE-CREATION 
>   applets/notes/package/contents/config/main.xml 596dfc0 
>   applets/notes/package/contents/ui/configAppearance.qml PRE-CREATION 
>   applets/notes/package/contents/ui/main.qml 1f1022c 
>   applets/notes/plugin/documenthandler.h 41cf704 
>   applets/notes/plugin/documenthandler.cpp 79c276e 
> 
> Diff: https://git.reviewboard.kde.org/r/124246/diff/
> 
> 
> Testing
> -------
> 
> Changing the font size from the config dialog and mousewheeling seems to work without screwing up your existing formatting.
> 
> Unfortunately the config dialog is quite difficult to get to since right clicking the text area yields the standard copy/paste menu and I failed to manually add another item for the applet config there
> 
> 
> File Attachments
> ----------------
> 
> Config dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/04/1d244f32-79e6-435c-a906-1acddede0aa3__stickylove3.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150704/ec761a18/attachment.html>