Review Request 124251: Support dropping a folder to the desktop creates a folderview

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124251/#review82071
-----------------------------------------------------------

Ship it!


Nice idea!

Tiny coding style nitpick: Please insert an empty line before the onExternalData handler.

- Eike Hein


On July 4, 2015, 3:03 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124251/
> -----------------------------------------------------------
> 
> (Updated July 4, 2015, 3:03 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This makes it offer to create a Folder view when dropping a folder onto the desktop rather than just a simple icon
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/FolderViewLayer.qml dc9d7de 
>   containments/folder/metadata.desktop 9ee67d9 
> 
> Diff: https://git.reviewboard.kde.org/r/124251/diff/
> 
> 
> Testing
> -------
> 
> Dropped a couple of folders ontop my desktop, got a folder view with the url set to the folder I just dropped
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150704/3c2c7779/attachment.html>