Review Request 124234: Add option to always show all system tray icons

[Heiko Tietze]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124234/#review82024
-----------------------------------------------------------


Nice addition. I was checking if users are able to realize the setting - and it is obvious since the drop down is hidden. However the layout of the checkbox is not really nice. Add more space to the details below and indent the siblings. Maybe it's worth to think about an alternativ text to allow accordance with the configurability of the dropdowns. E.g. 'Personalized tray icons', and enable/checked means you can change the details below.

- Heiko Tietze


On Juli 2, 2015, 9:23 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124234/
> -----------------------------------------------------------
> 
> (Updated Juli 2, 2015, 9:23 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 349812
>     https://bugs.kde.org/show_bug.cgi?id=349812
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/config/main.xml 8e8996c 
>   applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 
>   applets/systemtray/package/contents/ui/TaskDelegate.qml 221c6e7 
>   applets/systemtray/package/contents/ui/main.qml e794d1c 
>   applets/systemtray/plugin/host.h bd9728b 
>   applets/systemtray/plugin/host.cpp 5c897fa 
> 
> Diff: https://git.reviewboard.kde.org/r/124234/diff/
> 
> 
> Testing
> -------
> 
> Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options.
> 
> 
> File Attachments
> ----------------
> 
> Settings dialog (disabled)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png
> Settings dialog (enabled)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png
> System Tray (disabled)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png
> System Tray (enabled)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png
> Better dialog layout
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png
> Dim System Tray
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150702/6acdb4fd/attachment.html>