Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jul 1 23:07:32 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124215/
-----------------------------------------------------------

(Updated July 2, 2015, 1:07 a.m.)


Review request for Plasma.


Changes
-------

Use pkg-config so we're all happy. :)


Bugs: 349658
    https://bugs.kde.org/show_bug.cgi?id=349658


Repository: plasma-desktop


Description
-------

Instead of looking for X11 libraries and then looking stuff up, just find the directory we're looking for.
Also drop XBINDIR, as it wasn't being used at all.

Should give something like this directory:
```
$ ls /usr/share/X11/xkb/
compat  geometry  keycodes  rules  symbols  types
```


Diffs (updated)
-----

  ConfigureChecks.cmake 4fc4bce 
  config-workspace.h.cmake eda8996 
  kcms/keyboard/xkb_rules.cpp 9fd0324 

Diff: https://git.reviewboard.kde.org/r/124215/diff/


Testing
-------

re-compiled on my system, everything still works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150701/d363f0d8/attachment.html>


More information about the Plasma-devel mailing list