Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix
Marco Martin
notmart at gmail.com
Wed Jul 1 14:09:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124215/#review81948
-----------------------------------------------------------
+1 from here
- Marco Martin
On June 30, 2015, 2:53 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124215/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 2:53 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 349658
> https://bugs.kde.org/show_bug.cgi?id=349658
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Instead of looking for X11 libraries and then looking stuff up, just find the directory we're looking for.
> Also drop XBINDIR, as it wasn't being used at all.
>
> Should give something like this directory:
> ```
> $ ls /usr/share/X11/xkb/
> compat geometry keycodes rules symbols types
> ```
>
>
> Diffs
> -----
>
> kcms/keyboard/xkb_rules.cpp 9fd0324
> ConfigureChecks.cmake 4fc4bce
> config-workspace.h.cmake eda8996
>
> Diff: https://git.reviewboard.kde.org/r/124215/diff/
>
>
> Testing
> -------
>
> re-compiled on my system, everything still works.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150701/03d90bc1/attachment.html>
More information about the Plasma-devel
mailing list