Review Request 124204: Use proper relative paths to import js code

[Kevin Ottens]

> On June 29, 2015, 7:57 a.m., David Edmundson wrote:
> > Was this causing an error?
> 
> Kevin Ottens wrote:
>     Yes, most of the applets (see my other patches) were broken after my update this week-end. I didn't update in a while previously. I noted that the applets were inconsistent some using import "foo.js" (all broken for me) and some using import "../code/foo.js" (all working for me).
>     
>     Because of the inconsistency I went on making it consistent again picking the one which worked in practice.
>     
>     Note I'm testing with Qt 5.5 on my end.
> 
> David Edmundson wrote:
>     I have Qt5.5 here too; though maybe a month old.
>     
>     I'd rather we have some idea why it works for some and not your case, otherwise we have a risk that our 3rd party applets/existing stable releases are going to suddenly break and we'll have ignored the advanced warning.
>     
>     From what I can tell in PackageUrlInterceptor, when it tries searching for any relative URL inside something loaded from a package, it will look in every contentsPrefixPaths() i.e each registered folder in a plasma package structure; ui, code, config for that filename. 
>     
>     see packageurlinterceptor:127 it's not just for package:// urls.
>     
>     I don't understand why we do that, seems a bit weird to me, but we should keep compatibility if we've had that in previous releases.
>     
>     I'll update my Qt to see if that changes anything.
> 
> David Edmundson wrote:
>     Upgrade finished, still working without the patch needed.
>     
>     I'm building latest Qt 5.5 of everything, is that what you were using?
> 
> Kevin Ottens wrote:
>     I did a rebuild of everything and my qt5 repo is on the 5.5.0 branch (there might be differences between 5.5 and 5.5.0 branches ATM, hence why I point this out).

Of course I updated it all together.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/#review81844
-----------------------------------------------------------


On June 29, 2015, 7:15 a.m., Kevin Ottens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124204/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 7:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> Use proper relative paths to import js code
> 
> 
> Diffs
> -----
> 
>   src/applet/package/contents/ui/BluetoothApplet.qml 4e8b9648983edd2c8db242515464ae22d1e6fbe6 
>   src/applet/package/contents/ui/CompactRepresentation.qml 7085a7ec82fa88cb2d8e1a58847215845f3d5658 
> 
> Diff: https://git.reviewboard.kde.org/r/124204/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150701/fcbd763f/attachment.html>