Review Request 122342: Don't let notification popup accept focus
Thomas Lübking
thomas.luebking at gmail.com
Sat Jan 31 23:09:46 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122342/#review75113
-----------------------------------------------------------
+1
Even though I believe we should (default) the behavior in KWin, this is required for WMs which ignore the notification type (since it usually _is_ only a supportive hint on override_redirect ;-)
- Thomas Lübking
On Jan. 31, 2015, 6:44 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122342/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 6:44 nachm.)
>
>
> Review request for kwin, Plasma and Martin Klapetek.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This fixes eg. the systray popup closing when closing a notification. Thanks Thomas for spotting this.
>
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/NotificationPopup.qml 05cb4e7
>
> Diff: https://git.reviewboard.kde.org/r/122342/diff/
>
>
> Testing
> -------
>
> Popups no longer close, windows no longer lose focus, when interacting with a notification popup. I can still close them or click on action buttons. Makes them waaaaaay less painful and annoying.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150131/d35416d7/attachment.html>
More information about the Plasma-devel
mailing list