Review Request 122328: Fix apply button in breeze window decoration config

Hugo Pereira Da Costa hugo.pereira at free.fr
Fri Jan 30 12:02:50 UTC 2015


On 01/30/2015 12:58 PM, Pinak Ahuja wrote:
>
> I might be wrong, but shouldn't the changed signal have a bool 
> parameter? The changed() without a parameter refers to a slot(can we 
> emit a slot? I'm new to this). I didn't compile and check if the 
> behaviour was fixed in the master branch without this patch, I have 
> the problem with the plasma 5.2 package shipped with arch Linux.
>
ok. You're right, my bad. (even if I'm still not sure why it fixes the 
issue, the change is definitly correct)

Just sent a chip-it

Thanks !

Hugo


More information about the Plasma-devel mailing list