Review Request 122259: [ksld/greeter] Disable all IM modules

[Eike Hein]

> On Jan. 26, 2015, 12:41 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/greeter/main.cpp, line 56
> > <https://git.reviewboard.kde.org/r/122259/diff/1/?file=345290#file345290line56>
> >
> >     qunsetenv?
> 
> Martin Gräßlin wrote:
>     see bug report: Eike explicitly suggested to set it to empty, so I went for set empty instead of qunsetenv. As I have no way to test I do not know whether qunsetenv would be sufficient.
> 
> Martin Klapetek wrote:
>     Put a comment there, so someone else doesn't "fix" it.
> 
> Eike Hein wrote:
>     I'm sorry, I didn't actually mean to be explicit about that, I was just vague -- unsetting seems to work, too. But hold on, I'll have a look at the Qt code to see if there's any attempt at fallback in there to make sure.

OK, so if QT_IM_MODULE is unset or empty, Qt will currently fall back to the "compose" one, which is basic compose key support.

I'm wondering if we should actually explicitly set QT_IM_MODULE=compose to protect ourselves from possible future changes to that default behavior. I think it's likely that Qt will try harder to default to ibus in the future, since it's turned into the de-facto default on distros, and I expect it will soon be in use by all language users for emoji input. Then again, if this prediction comes true it probably means we need a more comprehensive fix for IME support in the screen locker anyway.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122259/#review74765
-----------------------------------------------------------


On Jan. 26, 2015, 12:38 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122259/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 12:38 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Bugs: 306932
>     https://bugs.kde.org/show_bug.cgi?id=306932
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> With IM modules it's possible that one cannot unlock the screen at
> all. So better disable all IM modules in the greeter.
> 
> BUG: 306932
> FIXED-IN: 5.2.1
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/main.cpp 44773631e66108e2aa1c5c6c6b97381b4a0316b2 
> 
> Diff: https://git.reviewboard.kde.org/r/122259/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150126/ed040665/attachment.html>