Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122239/
-----------------------------------------------------------

(Updated Jan. 24, 2015, 11:54 nachm.)


Review request for Plasma.


Changes
-------

QStringList is enough. That is unexpected, to say the least, and not standard JS behavior. But it's nice nonetheless.


Repository: kdeclarative


Description
-------

Since there are already like 10 copies of the ProcessRunner for all kinds of plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and KCMShell.open(["foo", "bar", "baz"]) singleton.


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff 
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed 

Diff: https://git.reviewboard.kde.org/r/122239/diff/


Testing
-------

Works. Dunno if the name causes clashes or this is the right place to put it.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150124/01ffda8e/attachment.html>