Review Request 122233: Fix global shortcut after configuration.

[Xuetian Weng]

> On Jan. 24, 2015, 11:32 a.m., Bhushan Shah wrote:
> > src/kded/kdedactions.cpp, line 49
> > <https://git.reviewboard.kde.org/r/122233/diff/1/?file=344489#file344489line49>
> >
> >     since isConfiguration itself is bool, 
> >     
> >     act->setProperty("isConfigurationAction", isConfiguration);

It's a dynamic property, thus not setting it can save some (insignificant, in this case) memory. :/


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122233/#review74654
-----------------------------------------------------------


On Jan. 24, 2015, 11:21 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122233/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 11:21 a.m.)
> 
> 
> Review request for Plasma and Lukáš Tinkl.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> -------
> 
> isConfigurationAction need to be set to true if QAction is only for configuration purpose, otherwise it will unregister from kglobalaccel daemon when destroyed.
> 
> 
> Diffs
> -----
> 
>   src/kcm/touchpadconfig.cpp 75494c2 
>   src/kded/kded.cpp 52389b6 
>   src/kded/kdedactions.h 200e466 
>   src/kded/kdedactions.cpp d2abc9c 
> 
> Diff: https://git.reviewboard.kde.org/r/122233/diff/
> 
> 
> Testing
> -------
> 
> After close shortcut configuration dialog and kcm, the global shortcut is still functional.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150124/43752033/attachment.html>