Review Request 122230: Continuously update notification timestamp

[Martin Klapetek]

> On Jan. 23, 2015, 11:13 p.m., David Edmundson wrote:
> > applets/notifications/package/contents/ui/NotificationItem.qml, line 94
> > <https://git.reviewboard.kde.org/r/122230/diff/1/?file=344436#file344436line94>
> >
> >     why 15 seconds?

It goes "now", if (time < 20 seconds) "10 seconds", if (time < 40 seconds) "30 seconds", else minutes.

15 seconds is imo enough, given this is not supposed to be exact time measurement.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122230/#review74641
-----------------------------------------------------------


On Jan. 23, 2015, 9:28 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122230/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 9:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> While the popup is opened update the timestamps, especially the first ones (Just now, 10s ago, 30s ago) come in quick succession making it feel weird for them to only update when opening the dialog. Even simplifies the code now.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationItem.qml c476749 
> 
> Diff: https://git.reviewboard.kde.org/r/122230/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150123/9bac2484/attachment.html>