Review Request 122065: Fix activity start and stop.

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/#review74574
-----------------------------------------------------------


This looks still wrong to me. The service is still called "org.kde.kwin" while it should be "org.kde.KWin". Ideally this gets changed to a generated adaptor from the DBus interface KWin installs.

To make things worse: the service name is not guaranteed to be "org.kde.KWin" - it can be mangled on multi-head systems. I had considered eporting it to a root window property, maybe I should implement that.

- Martin Gräßlin


On Jan. 23, 2015, 12:42 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122065/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 12:42 a.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> 1. KWin Interface name is wrong
> 2. kactivitymanagerd doesn't listen on ksmserver anymore, thus subSession{Opened,Closed,CloseCanceled} are not called anymore. It need to send Started/Stopped event by itself when kwin dbus call returns.
> 
> 
> Diffs
> -----
> 
>   src/service/ksmserver/KSMServer_p.h c0f5598 
>   src/service/ksmserver/KSMServer.cpp b5e1467 
> 
> Diff: https://git.reviewboard.kde.org/r/122065/diff/
> 
> 
> Testing
> -------
> 
> Now starting and stopping activity works properly.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150123/e1243fd3/attachment.html>