Review Request 122207: [plasma-desktop] Make tests optional

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Thu Jan 22 21:02:19 UTC 2015



> On Jan. 22, 2015, 8:48 p.m., David Edmundson wrote:
> > Ship It!

I should add that I don't have write access, so I ask for someone else to merge it. :)


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122207/#review74560
-----------------------------------------------------------


On Jan. 22, 2015, 8:04 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122207/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 8:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is a small patch for CMakeLists.txt to only require Qt5Test if BUILD_TESTING.
> Also changed
> kcms/keyboard/CMakeLists.txt
> kcms/lookandfeel/CMakeLists.txt
> to only add test subdirs if BUILD_TESTING.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/CMakeLists.txt 6ed3cd7bd597c987b96131e44b5ed3d098d43319 
>   kcms/lookandfeel/CMakeLists.txt 5f5defd83cbb9b148b172978f92f55e2185ff340 
>   CMakeLists.txt 4fc6a1dd3e53585d304a4c4143e262c825d83c3a 
> 
> Diff: https://git.reviewboard.kde.org/r/122207/diff/
> 
> 
> Testing
> -------
> 
> Built with and without test.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150122/6b9e879d/attachment.html>


More information about the Plasma-devel mailing list