Review Request 122196: Offer the option to show per-field binary instead of per-digit

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122196/#review74527
-----------------------------------------------------------


Hey. Thanks for writing a patch, at a quick glance it looks like it would work well.

Unfortunately we are not making any more releases for Plasma4 software, and introducing a new string (text) that needs to be translated really isn't allowed now it is frozen. What I suggest for this feature is to make a tarball with just the binary clock and upload it to kde-look.org, there's not a lot else we can do.


Under Plasma 5 all UI is done through QML so this patch wouldn't really apply directly, though you could transfer the logic. The binary clock applet has not been ported, so maybe it's something you could look into.

Sorry.

- David Edmundson


On Jan. 22, 2015, 6:47 a.m., Patrick Uiterwijk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122196/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 6:47 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Offer the option to show per-field binary instead of per-digit
> 
> 
> Diffs
> -----
> 
>   applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 
>   applets/binary-clock/binaryclock.cpp 3b8c7af4631fcb60437045eae37d0c0552c85299 
>   applets/binary-clock/clockConfig.ui 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 
> 
> Diff: https://git.reviewboard.kde.org/r/122196/diff/
> 
> 
> Testing
> -------
> 
> I have compiled a patched version of kdeplasma-addons on a recent version of Fedora (22), and am using it myself.
> 
> 
> Thanks,
> 
> Patrick Uiterwijk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150122/1f235170/attachment.html>