Review Request 122119: Port PlasmaComponents TextArea and TextField to KQuickControls

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122119/#review74312
-----------------------------------------------------------


+1 from me.

- David Edmundson


On Jan. 17, 2015, 11:36 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122119/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 11:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This ports those two components to the new KQuickControls ones that features a full context menu.
> 
> Note that this requires Qt 5.4 (QtQuick.Controls 1.3), so might needs to be postponed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextArea.qml 1fcbb5b 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml c027add 
> 
> Diff: https://git.reviewboard.kde.org/r/122119/diff/
> 
> 
> Testing
> -------
> 
> Ran both tests in qmlscene and works as before with the new context menu.
> 
> I noticed that in KRunner I get a widget-like context menu with shadows and all whereas in plasmoids (kickoff and klipper) I get an out-of-place looking menu without shadows and using Plasma highlight. This is probably it using Plasma's MenuStyle rather than the desktop style.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150119/bccae14d/attachment.html>