Review Request 122119: Port PlasmaComponents TextArea and TextField to KQuickControls

[David Edmundson]

> On Jan. 17, 2015, 11:47 p.m., Aleix Pol Gonzalez wrote:
> > The change looks off. Shouldn't this go to either the QQC theme or upstream? Changing from using Qt components to our own thing is kind of against what we've been working for.

I think this is the best we're going to get. It will be hard to put the menu upstream; and we will certainly never get Sonnet in there.

We currently have 2 scenarios:
User uses QtQuick.Controls.TextArea
User uses KQuickControls.TextArea and gets some KDE enhanced functions. It really shouldn't be in the theme as it's adding functions and API.

both of these can be used with or without the Plasma style.

The only thing this is changing is what happens when you PlasmaComponents directly, do you get the QQC one or the enhanced KDE one.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122119/#review74209
-----------------------------------------------------------


On Jan. 17, 2015, 11:36 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122119/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 11:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This ports those two components to the new KQuickControls ones that features a full context menu.
> 
> Note that this requires Qt 5.4 (QtQuick.Controls 1.3), so might needs to be postponed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextArea.qml 1fcbb5b 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml c027add 
> 
> Diff: https://git.reviewboard.kde.org/r/122119/diff/
> 
> 
> Testing
> -------
> 
> Ran both tests in qmlscene and works as before with the new context menu.
> 
> I noticed that in KRunner I get a widget-like context menu with shadows and all whereas in plasmoids (kickoff and klipper) I get an out-of-place looking menu without shadows and using Plasma highlight. This is probably it using Plasma's MenuStyle rather than the desktop style.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150119/8f2af453/attachment.html>