Review Request 121563: Fix build with Qt 5.5/dev branch in release mode

Hrvoje Senjan hrvoje.senjan at gmail.com
Sat Jan 17 17:12:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121563/
-----------------------------------------------------------

(Updated Jan. 17, 2015, 6:12 p.m.)


Review request for Plasma.


Changes
-------

guard the assert instead


Repository: libksysguard


Description
-------

same as review 121562:
"since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c "Make the empty Q_ASSERT still check its argument for validity" the build shall fail.
alternative is to guard the Q_ASSERT with QT_NO_DEBUG"


Diffs (updated)
-----

  processcore/processes.cpp 6c0effc 

Diff: https://git.reviewboard.kde.org/r/121563/diff/


Testing
-------

builds with both 5.4 & dev branch


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150117/f1401b1a/attachment.html>


More information about the Plasma-devel mailing list