Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

[Filip Wieladek]

> On Jan. 17, 2015, 12:55 p.m., David Edmundson wrote:
> > So I assume the bug is:
> >  - the menu handles all up/down/enter, then forwards all keys onto the line edit which is a child widget
> >  - that child widget doesn't handle shift so it automatically goes back up to the parent, and we recurse
> >    
> > would be nice to have some code comments explaining it for the next person who edits this file.
> > 
> > Do you have commit access?

Yes. I added the description in the KDE bug report here: https://bugs.kde.org/show_bug.cgi?id=342947. 

I can add the comments if you want. I usually prefer to have the discussion in the bug tracking software and use annotate, but I'll add the comments. I do not have commit access


- Filip


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122106/#review74174
-----------------------------------------------------------


On Jan. 17, 2015, noon, Filip Wieladek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122106/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, noon)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Fix the infinite event recursion in the klipper popup. See Bug 342947
> 
> 
> Diffs
> -----
> 
>   klipper/klipperpopup.h 4e03714fba1e7f16868a6d3c40f43528e055f860 
>   klipper/klipperpopup.cpp 56c6421b33dd5a28b3a5b5eef54147acaee6dfbc 
> 
> Diff: https://git.reviewboard.kde.org/r/122106/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Filip Wieladek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150117/c01ebdbc/attachment.html>