Change in plasma-framework[master]: Hack: silence failing test on Qt 5.2

Jan Kundrát (Code Review) noreply at kde.org
Wed Jan 14 15:40:11 UTC 2015


Jan Kundrát has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/324

Change subject: Hack: silence failing test on Qt 5.2
......................................................................

Hack: silence failing test on Qt 5.2

I guess nobody cares enough to debug why this fails on Qt 5.2, so let's
just silence this error blacklisting this particular test case on Qt
prior to 5.3.

I have no idea whether this is a good fix.

BUG: 342676
Change-Id: Ib53b70f740157e1a06383a9f0a78c3fccf5b930c
---
M autotests/dialognativetest.cpp
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/24/324/1

diff --git a/autotests/dialognativetest.cpp b/autotests/dialognativetest.cpp
index 6811202..7ddc228 100644
--- a/autotests/dialognativetest.cpp
+++ b/autotests/dialognativetest.cpp
@@ -81,9 +81,11 @@
     QCOMPARE(m_dialog->x(), 0);
     QCOMPARE(m_dialog->y(), 49);
 
+#if QT_VERSION >= QT_VERSION_CHECK(5, 3, 0)
     m_dialog->setVisualParent(m_panel2->contentItem());
     QCOMPARE(m_dialog->x(), 71);
     QCOMPARE(m_dialog->y(), 49);
+#endif
 }
 
 QTEST_MAIN(DialogNativeTest)

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/324
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib53b70f740157e1a06383a9f0a78c3fccf5b930c
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: Jan Kundrát <jkt at kde.org>


More information about the Plasma-devel mailing list