Review Request 121929: Added Compact Bar type to look like old System Load Viewer. Swapped the cached and buffers default colours
Martin Yrjölä
martin.yrjola at gmail.com
Fri Jan 9 06:42:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121929/
-----------------------------------------------------------
Review request for Plasma and David Edmundson.
Repository: kdeplasma-addons
Description
-------
I posted this code review on behalf of Joshua Worth. He has ported the old system load viewer style consisting of borderless bars with gradients. It makes the plasmoid use less room in the panel. I have already reviewed the code.
-Martin Yrjölä
Diffs
-----
applets/systemloadviewer/package/contents/ui/GeneralSettings.qml 11550d567dac1bbe55e86793bc00adbca529aff7
applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 558fe6f2a01e43f5cd67498f526e1d411839beca
applets/systemloadviewer/package/contents/config/main.xml 89a94832595a38311c312cc4a0621b60f3aac750
applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml PRE-CREATION
applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml dfb03e54c6702bda3d995b11c7038db2eacb94fd
Diff: https://git.reviewboard.kde.org/r/121929/diff/
Testing
-------
Works on both desktop and panel. I didn't discover any breakage.
-Martin Yrjölä
File Attachments
----------------
Testing and comparison
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/08/b743ccc8-0955-433c-8720-1f438c4975d4__snapshot1.png
Thanks,
Martin Yrjölä
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150109/342d3799/attachment.html>
More information about the Plasma-devel
mailing list