Review Request 121790: Port plasmasehll away from kscreen

Aleix Pol Gonzalez aleixpol at kde.org
Fri Jan 2 14:38:17 UTC 2015



> On Jan. 2, 2015, 2:25 p.m., Aleix Pol Gonzalez wrote:
> > How do you figure out what's the primary screen with QScreen?
> > https://bugreports.qt-project.org/browse/QTBUG-38404
> > 
> > -2
> 
> Lukáš Tinkl wrote:
>     Ugh, that's nasty, I wasn't aware of this bug...

Yes, well, I don't know. People keep discussing the dependency of KScreen as if it was something that happened because there was an explicit interest for using it. I spent quite some time with the port and it was (and still is) the only option.

Fixing Qt is possible, but I'm quite sure it won't happen if we don't make it happen. Changing hte Plasma side, is indeed the easy part.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121790/#review72949
-----------------------------------------------------------


On Jan. 2, 2015, noon, Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121790/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, noon)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed.
> 
> Drawbacks:
> - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c6d89c1 
>   shell/CMakeLists.txt cb48ab8 
>   shell/panelview.h d1ef282 
>   shell/panelview.cpp b7f043d 
>   shell/shellcorona.h 3321adf 
>   shell/shellcorona.cpp c26efe5 
> 
> Diff: https://git.reviewboard.kde.org/r/121790/diff/
> 
> 
> Testing
> -------
> 
> To disable ext screen: xrandr --output HDMI3 --off
> To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150102/4639e71b/attachment.html>


More information about the Plasma-devel mailing list