Review Request 121790: Port plasmasehll away from kscreen

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121790/#review72938
-----------------------------------------------------------


Definitely where we want to go long term, and if it fixes our immediate main problem then maybe we should aim for 5.2

The KScreen changes were done because QScreen had problems not just for fun. I really want to put this under some stress testing to make sure we don't regress anything.


shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/121790/#comment50771>

    maybe put screen->name() here too so it matches with SCREEN ADDED. Will make debugging easier.



shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/121790/#comment50772>

    We still need this.
    
    It's for the case where we have mirrored mode
    i.e two screens on top of each other.
    
    That will still happen with QScreen.



shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/121790/#comment50773>

    slightly offtopic, but maybe this is the cause of our original kscreen error.
    
    With the kscreen part now being out of process, we might be processing KScreens before the XCB backend of plasmashell has had a chance to load everything. 
    
    Previously when it was in process we just had to wait one event loop to be sure that they were using the same data and in sync.


- David Edmundson


On Jan. 2, 2015, noon, Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121790/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, noon)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed.
> 
> Drawbacks:
> - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c6d89c1 
>   shell/CMakeLists.txt cb48ab8 
>   shell/panelview.h d1ef282 
>   shell/panelview.cpp b7f043d 
>   shell/shellcorona.h 3321adf 
>   shell/shellcorona.cpp c26efe5 
> 
> Diff: https://git.reviewboard.kde.org/r/121790/diff/
> 
> 
> Testing
> -------
> 
> To disable ext screen: xrandr --output HDMI3 --off
> To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150102/de81333f/attachment.html>