Review Request 121774: Let month menu navigate in current year

Martin Klapetek martin.klapetek at gmail.com
Fri Jan 2 12:08:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121774/#review72936
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On Dec. 31, 2014, 11:39 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121774/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 11:39 a.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 342327
>     http://bugs.kde.org/show_bug.cgi?id=342327
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Rather than jumping back to the current year unconditionally just navigate inside the current year. We might need to add a separate year menu/spinbox somehow also.
> 
> Also use the nifty Instantiator rather than 12x copy paste.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/MonthMenu.qml 6b0fb96 
>   src/declarativeimports/calendar/qml/MonthView.qml 11013a7 
> 
> Diff: https://git.reviewboard.kde.org/r/121774/diff/
> 
> 
> Testing
> -------
> 
> Works fine, changing the month through the menu keeps the current year.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150102/195b390c/attachment.html>


More information about the Plasma-devel mailing list