Review Request 121763: Fix build on FreeBSD

[Raphael Kubo da Costa]

> On Jan. 2, 2015, 10:24 a.m., Martin Gräßlin wrote:
> > Modules/info/CMakeLists.txt, lines 28-30
> > <https://git.reviewboard.kde.org/r/121763/diff/1/?file=337463#file337463line28>
> >
> >     just out of interest: is devinfo a FreeBSD only library or is it of interest for more non-Linux variants?

It's a library that originated on FreeBSD (http://mdoc.su/f/devinfo.3) and as far as I can tell only DragonFlyBSD also uses/ships it, so I wouldn't worry about making the check more generic for now (I don't use DragonFly myself, but I remember some checks used to work for both OSes). If someone from DragonFlyBSD complains at some point, we can turn this into a proper Find module.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121763/#review72900
-----------------------------------------------------------


On Dec. 30, 2014, 8:48 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121763/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 8:48 p.m.)
> 
> 
> Review request for Plasma and Raphael Kubo da Costa.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> We can't call the KCM devinfo there since we need to link against -ldevinfo
> and CMake would try to link to the KCM instead of the library in that case.
> 
> 
> Diffs
> -----
> 
>   Modules/devinfo/CMakeLists.txt 2395ce3dc83080e959cbfa9f97724218cdff6bd9 
>   Modules/devinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7 
>   Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b 
>   Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1 
> 
> Diff: https://git.reviewboard.kde.org/r/121763/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150102/58d591b8/attachment.html>