Review Request 121761: Fix build on FreeBSD

[Martin Gräßlin]

> On Dec. 31, 2014, 3:19 p.m., Pino Toscano wrote:
> > ksmserver/screenlocker/greeter/autotests/killtest.cpp, lines 79-82
> > <https://git.reviewboard.kde.org/r/121761/diff/1/?file=337442#file337442line79>
> >
> >     This (and all the other cases of this) should rather be:
> >     ```
> >     #ifdef SIGUNUSED
> >      ...
> >     #endif
> >     ```
> >     so the code using this signal is built when it is available, not just "on Linux/$OS".

that's just a unit test, let's not make it too complicated.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121761/#review72846
-----------------------------------------------------------


On Dec. 30, 2014, 7:33 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121761/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 7:33 p.m.)
> 
> 
> Review request for Plasma and Raphael Kubo da Costa.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Add missing errno.h include
> 
> Wrap Linux-only signals in #ifdef Q_OS_LINUX
> 
> Fix build with X11 not installed to /usr
> 
> 
> Diffs
> -----
> 
>   drkonqi/detachedprocessmonitor.cpp 85a87874c6e9ce47856a01195b42aef9f3a4991a 
>   drkonqi/systeminformation.cpp 8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db 
>   ksmserver/CMakeLists.txt 84a8aa393dfb6ed4671094d1fccbb3c79c53f9af 
>   ksmserver/screenlocker/greeter/authenticator.cpp ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a 
>   ksmserver/screenlocker/greeter/autotests/killtest.cpp 6f2ef114459b5d641e357f3a817b82e7af2e72a3 
>   libkworkspace/CMakeLists.txt 53ce6108bd91f87108206fca02ac303dadf069e1 
> 
> Diff: https://git.reviewboard.kde.org/r/121761/diff/
> 
> 
> Testing
> -------
> 
> compiles, still compiles on linux
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150102/8cdcb4a5/attachment-0001.html>