Review Request 122736: [dataengines/geolocation] Use wifi data if available

[Martin Gräßlin]

> On Feb. 27, 2015, 10:42 a.m., Jan Grulich wrote:
> > dataengines/geolocation/location_ip.cpp, line 149
> > <https://git.reviewboard.kde.org/r/122736/diff/1/?file=351954#file351954line149>
> >
> >     SSID is never empty (at least it shouldn't be), if it would be a hidden AP it wouldn't be listed between networks, but I think that newer NM versions make hidden APs visible anyway.

so how can I check for a hidden AP? They are not supposed to be sent to the service.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122736/#review76704
-----------------------------------------------------------


On Feb. 27, 2015, 10:13 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122736/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 10:13 a.m.)
> 
> 
> Review request for Plasma, Jan Grulich and Lukáš Tinkl.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Adds a dependency to NetworkManager and queries the available wifi
> access points to include in the request to the location service.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 
>   dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5 
>   dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e 
>   dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e 
>   dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc 
> 
> Diff: https://git.reviewboard.kde.org/r/122736/diff/
> 
> 
> Testing
> -------
> 
> Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150227/8ed2fa2a/attachment-0001.html>