Review Request 122726: Make touchpad KCM optional depending on whether we find synaptics

David Edmundson david at davidedmundson.co.uk
Thu Feb 26 13:53:41 UTC 2015



> On Feb. 26, 2015, 12:22 p.m., Martin Klapetek wrote:
> > cmake/modules/FindSynaptics.cmake, line 26
> > <https://git.reviewboard.kde.org/r/122726/diff/1/?file=351820#file351820line26>
> >
> >     Shouldn't this also look for the lib? Or is that not needed for linking?

there is no lib.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122726/#review76647
-----------------------------------------------------------


On Feb. 25, 2015, 11:02 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122726/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 11:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Make touchpad KCM optional depending on whether we find synaptics
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f98a189 
>   cmake/modules/FindSynaptics.cmake PRE-CREATION 
>   kcms/CMakeLists.txt 5ff1780 
>   kcms/touchpad/src/backends/x11.cmake 3496333 
> 
> Diff: https://git.reviewboard.kde.org/r/122726/diff/
> 
> 
> Testing
> -------
> 
> Mine still builds.. .once pushed we'll find out if build.kde.org passes again.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150226/8678afd7/attachment.html>


More information about the Plasma-devel mailing list