Review Request 122715: tooltip: Fix left margin in text-only tooltips

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122715/
-----------------------------------------------------------

(Updated Feb. 25, 2015, 5:26 p.m.)


Review request for Plasma.


Changes
-------

Fix a regression in icon sizing which crept in with the last revision


Repository: plasma-framework


Description
-------

tooltip: Fix left margin in text-only tooltips

Changelog: Fix text-only tooltips' left margin

The approach taken is a bit ugly, since we don't have control over exact placing due to the usage of Row and Column. The existing x and y properties are also pretty ugly. I'm going for a spacer object and making the spacing zero here, as that is much easier to compute than preventing from double or triple spacing.

I think this code needs a rewrite. This is a minimal approach to fixing the alignment of the pager, for example.


Diffs (updated)
-----

  src/declarativeimports/core/private/DefaultToolTip.qml d1be6ae 

Diff: https://git.reviewboard.kde.org/r/122715/diff/


Testing
-------

Tested pager individually, checked all tooltip from the panel for visual regressions.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150225/d2f6402d/attachment.html>