Review Request 122704: Set aboutdata for plasmashell

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122704/#review76516
-----------------------------------------------------------

Ship it!


As I looked into it yesterday: without setting KAboutData the KCrash framework is not able to extract the information.

- Martin Gräßlin


On Feb. 24, 2015, 8:14 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122704/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 8:14 a.m.)
> 
> 
> Review request for Plasma and Christoph Feck.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch sets aboutdata for plasmashell,
> 
> If aboutData is not set it results in some problems, for example kcrash do not report to right product for crash on bko
> 
> For example see following bug reports
> 
> https://bugs.kde.org/show_bug.cgi?id=344471
> https://bugs.kde.org/show_bug.cgi?id=344323
> 
> They gets reported to kde/general
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 21b25a3 
>   shell/main.cpp 987bf44 
> 
> Diff: https://git.reviewboard.kde.org/r/122704/diff/
> 
> 
> Testing
> -------
> 
> Reported two new bugs, in first bug it was reported to kde/general because plasmashell didn't had version number for 5.2.90, second bug got reported properly
> 
> https://bugs.kde.org/show_bug.cgi?id=344513
> https://bugs.kde.org/show_bug.cgi?id=344514
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150224/acc8a762/attachment-0001.html>