Review Request 122696: Bump the version of the QML import

Aleix Pol Gonzalez aleixpol at kde.org
Tue Feb 24 00:13:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122696/#review76511
-----------------------------------------------------------



src/declarativeimports/core/corebindingsplugin.cpp
<https://git.reviewboard.kde.org/r/122696/#comment52687>

    That's not correct. SortFilterModel is already available on 2.0. If a property was introduced, then modify it on the Q_PROPERTY definition.


- Aleix Pol Gonzalez


On Feb. 23, 2015, 8:20 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122696/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 8:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Now I don't know if bumping just this one is good/enough or if all of them should be raised. Please advise.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/corebindingsplugin.cpp ed241ba 
> 
> Diff: https://git.reviewboard.kde.org/r/122696/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150224/50474f69/attachment.html>


More information about the Plasma-devel mailing list