Review Request 122695: Add plain string filtering capability to SortFilterModel

[Martin Klapetek]

> On Feb. 23, 2015, 5:41 p.m., David Edmundson wrote:
> > +1 code looks fine.
> > 
> > as for version bumps, we've introduced API elsewhere without doing that.
> 
> Martin Klapetek wrote:
>     If we're talking about the QML import versions, then maybe we should start?
> 
> Marco Martin wrote:
>     never really cared about qml versioning.. doesn't buy much, as an application written using newer api wouldn't work anyways and i don't want to allow for api removal or too big api change anyways
>     
>     but, if we are going to start, should only be minor version change, not 3.0

Well I think it's the right thing to do(tm) but if you don't consider it important, then meh, let's just focus on the diff at hand.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122695/#review76480
-----------------------------------------------------------


On Feb. 23, 2015, 5:25 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122695/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 5:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Filtering only by regexps is not enough because as soon as filtering by special characters is needed, they can get interpreted as regexp special characters and stuff will break.
> 
> I also sense there should be a version bump of the import, but I'm unsure to what - it's 2.0 right now, should it be 2.1 or 3.0?
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/datamodel.h f0a6ee2 
>   src/declarativeimports/core/datamodel.cpp 3978556 
> 
> Diff: https://git.reviewboard.kde.org/r/122695/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150223/151e1735/attachment.html>