Review Request 122695: Add plain string filtering capability to SortFilterModel
David Edmundson
david at davidedmundson.co.uk
Mon Feb 23 16:41:33 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122695/#review76480
-----------------------------------------------------------
+1 code looks fine.
as for version bumps, we've introduced API elsewhere without doing that.
- David Edmundson
On Feb. 23, 2015, 4:25 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122695/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 4:25 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Filtering only by regexps is not enough because as soon as filtering by special characters is needed, they can get interpreted as regexp special characters and stuff will break.
>
> I also sense there should be a version bump of the import, but I'm unsure to what - it's 2.0 right now, should it be 2.1 or 3.0?
>
>
> Diffs
> -----
>
> src/declarativeimports/core/datamodel.h f0a6ee2
> src/declarativeimports/core/datamodel.cpp 3978556
>
> Diff: https://git.reviewboard.kde.org/r/122695/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150223/ebe77f37/attachment.html>
More information about the Plasma-devel
mailing list