Review Request 122648: Make notifications --reverse aware
Martin Klapetek
martin.klapetek at gmail.com
Mon Feb 23 12:13:06 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122648/
-----------------------------------------------------------
(Updated Feb. 23, 2015, 1:13 p.m.)
Review request for Plasma.
Changes
-------
Final version
Bugs: 343251
https://bugs.kde.org/show_bug.cgi?id=343251
Repository: plasma-workspace
Description
-------
Now it works with plasmashell --reverse
Diffs (updated)
-----
applets/notifications/package/contents/ui/NotificationItem.qml 86b0b6e
applets/notifications/package/contents/ui/NotificationPopup.qml 6902459
applets/notifications/package/contents/ui/main.qml 1e5efa3
applets/notifications/plugin/notificationshelper.h ca0b63b
applets/notifications/plugin/notificationshelper.cpp e7c4e29
Diff: https://git.reviewboard.kde.org/r/122648/diff/
Testing
-------
Tested both --reverse and not --reverse and both look good. See screenshot.
File Attachments
----------------
--reverse
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/20/5058fe12-ecdd-4345-bcec-4392bbfa78f5__notifications-reverse.png
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150223/edba38b0/attachment.html>
More information about the Plasma-devel
mailing list