Review Request 122676: Use our internal blur enabled variable for the texture

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122676/#review76449
-----------------------------------------------------------

Ship it!


Looks right to me.

- Martin Gräßlin


On Feb. 22, 2015, 4:04 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122676/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 4:04 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 344179
>     http://bugs.kde.org/show_bug.cgi?id=344179
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Since we already watch blurEnabled ourselves, we should use that variable to determin which SVGs to load. KWindowEffects::isEffectAvailable might not have caught up yet when we decide do nuke the cache resulting in the translucent graphics staying when enabling/disabling Blur or swtiching to XRender.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/theme_p.cpp f3c1e89 
> 
> Diff: https://git.reviewboard.kde.org/r/122676/diff/
> 
> 
> Testing
> -------
> 
> Switching from OpenGL to XRender now properly switches to the opaque textures.
> I'm not sure whether that's a bug in KWindowEffects, but then, less roundtrips are always good :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150223/7f075507/attachment.html>