Review Request 122662: Meta-Tab activity switching for plasma-desktop

Marco Martin notmart at gmail.com
Sat Feb 21 17:54:28 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122662/#review76395
-----------------------------------------------------------

Ship it!



desktoppackage/contents/activitymanager/ActivityManager.qml
<https://git.reviewboard.kde.org/r/122662/#comment52618>

    208, eeew:)


- Marco Martin


On Feb. 21, 2015, 4:46 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122662/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2015, 4:46 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This patch provides the following:
> 
> 1. A C++ backend object for activity switcher
> 
> - provides cached wallpaper thumbnails for faster switcher loading
> - registers the keyboard shortcuts for activity switching
> 
> 
> 2. Patch to the UI
> 
> - To show the switcher when the user switches activities via the keyboard shortcut (it shows the version without advanced controls like search and activity creation / manipulation)
> - Merged ActivityBrowser.qml and ActivityManager.qml into one
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/activitymanager/ActivityList.qml 8baa801 
>   desktoppackage/contents/activitymanager/ActivityManager.qml ce2712c 
>   desktoppackage/contents/views/Desktop.qml 319da90 
>   imports/activitymanager/CMakeLists.txt PRE-CREATION 
>   imports/activitymanager/activityswitcherextensionplugin.h PRE-CREATION 
>   imports/activitymanager/activityswitcherextensionplugin.cpp PRE-CREATION 
>   imports/activitymanager/qmldir PRE-CREATION 
>   imports/activitymanager/switcherbackend.h PRE-CREATION 
>   CMakeLists.txt 7c6284c 
>   desktoppackage/contents/activitymanager/ActivityBrowser.qml 1ea5e2b 
>   desktoppackage/contents/activitymanager/ActivityItem.qml e34402b 
>   imports/activitymanager/switcherbackend.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122662/diff/
> 
> 
> Testing
> -------
> 
> There are two issues currently:
> - one for showing the wallpapers on meta-tab switcher mode
> - the activity switching has an artificial delay because plasma dead-locks if the side panel is loaded while the activity is being switched.
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150221/b06d5e0a/attachment.html>


More information about the Plasma-devel mailing list