Review Request 122660: Breeze Decoration Redesign

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122660/#review76383
-----------------------------------------------------------


Personally I find the colored circles quite distracting, if I may say so. In my humble opinion, it would be better if those only appeared/colored(from gray?) on mouse over.

- Martin Klapetek


On Feb. 21, 2015, 3:53 p.m., Ken Vermette wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122660/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2015, 3:53 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Overhaul of the Breeze Window decoration drawing code; 
>  - Redesigned buttons and tweaked the titlebar slightly. 
>  - Updated the behaviour of the resize grip - fixed bug for fullscreen
>  - Font weight will now affect the boldness of icons in buttons
> 
> Note; Buttons are not animated yet in this variant.
> 
> 
> Diffs
> -----
> 
>   kdecoration/breezebutton.cpp 5ac0cfe 
>   kdecoration/breezedecoration.h 9eb6c65 
>   kdecoration/breezedecoration.cpp b474a8b 
>   kdecoration/breezebutton.h c43959a 
> 
> Diff: https://git.reviewboard.kde.org/r/122660/diff/
> 
> 
> Testing
> -------
> 
> - Tried out preinstalled colours schemes to ensure consistent colouring
>  - Viewed various button sizes
> 
> 
> File Attachments
> ----------------
> 
> Updated Decos
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/21/66f8d3d8-5852-4b79-b211-339cbc7bf712__newdecos.png
> Full Windows
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/21/20580b13-3bb1-4020-9ddf-8d1253184a45__snapshot1.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150221/d1340d4f/attachment-0001.html>