Review Request 122660: Breeze Decoration Redesign

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122660/#review76370
-----------------------------------------------------------



kdecoration/breezedecoration.cpp
<https://git.reviewboard.kde.org/r/122660/#comment52607>

    ?



kdecoration/breezedecoration.cpp
<https://git.reviewboard.kde.org/r/122660/#comment52608>

    unused?



kdecoration/breezedecoration.cpp
<https://git.reviewboard.kde.org/r/122660/#comment52610>

    reconfigure is rather expensive, it should be reloading entire configs. You don't want to do that on every change.
    
    I'd split the relevant part into a new function
    updateSizeGrip()
    
    which has the relevant code from reconfigure() then call updateSizeGrip() from reconfigure or when maximise or active changes.



kdecoration/breezedecoration.cpp
<https://git.reviewboard.kde.org/r/122660/#comment52609>

    not part of your patch: why is this commented out?



kdecoration/breezedecoration.cpp
<https://git.reviewboard.kde.org/r/122660/#comment52612>

    this is still const?



kdecoration/breezedecoration.cpp
<https://git.reviewboard.kde.org/r/122660/#comment52611>

    you have a TODO isActive then check it in the line below



kdecoration/breezedecoration.cpp
<https://git.reviewboard.kde.org/r/122660/#comment52613>

    try not to change coding styles.


- David Edmundson


On Feb. 21, 2015, 11:14 a.m., Ken Vermette wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122660/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2015, 11:14 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Overhaul of the Breeze Window decoration drawing code; 
>  - Redesigned buttons and tweaked the titlebar slightly. 
>  - Updated the behaviour of the resize grip - fixed bug for fullscreen
>  - Font weight will now affect the boldness of icons in buttons
> 
> Note; Buttons are not animated yet in this variant.
> 
> 
> Diffs
> -----
> 
>   kdecoration/breezebutton.h c43959a 
>   kdecoration/breezebutton.cpp 5ac0cfe 
>   kdecoration/breezedecoration.h 9eb6c65 
>   kdecoration/breezedecoration.cpp b474a8b 
> 
> Diff: https://git.reviewboard.kde.org/r/122660/diff/
> 
> 
> Testing
> -------
> 
> - Preinstalled colours schemes to ensure consistent colouring
>  - Viewed various button sizes
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150221/acaca73d/attachment-0001.html>