Review Request 122648: Make notifications --reverse aware

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122648/
-----------------------------------------------------------

(Updated Feb. 20, 2015, 9:07 p.m.)


Review request for Plasma.


Changes
-------

Fixed anchors and now also the popup position is switched.

The NotificationPopup needs its own LayoutMirroring because it's not a child of anything.

(and also remove accidental whitespace)


Bugs: 343251
    https://bugs.kde.org/show_bug.cgi?id=343251


Repository: plasma-workspace


Description
-------

Now it works with plasmashell --reverse


Diffs (updated)
-----

  applets/notifications/plugin/notificationshelper.cpp e7c4e29 
  applets/notifications/package/contents/ui/main.qml 1e5efa3 
  applets/notifications/plugin/notificationshelper.h ca0b63b 
  applets/notifications/package/contents/ui/NotificationPopup.qml 6902459 
  applets/notifications/package/contents/ui/NotificationItem.qml 86b0b6e 

Diff: https://git.reviewboard.kde.org/r/122648/diff/


Testing
-------

Tested both --reverse and not --reverse and both look good. See screenshot.


File Attachments
----------------

--reverse
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/20/5058fe12-ecdd-4345-bcec-4392bbfa78f5__notifications-reverse.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150220/d16ebfdb/attachment.html>