Review Request 122648: Make notifications --reverse aware
David Edmundson
david at davidedmundson.co.uk
Fri Feb 20 15:03:05 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122648/#review76339
-----------------------------------------------------------
applets/notifications/package/contents/ui/NotificationItem.qml
<https://git.reviewboard.kde.org/r/122648/#comment52600>
Just
LayoutMirroring.enabled: true
and then it will swap only if layoutDirection == RTL
otherwise we're implicitly checking twice.
https://paste.kde.org/pl8jqrfzl <--- proof.
anchors are also affected by LayoutMirroring; if you want to mirror everything just LayoutMirroring.enabled on the root object?
- David Edmundson
On Feb. 20, 2015, 2:51 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122648/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2015, 2:51 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 343251
> https://bugs.kde.org/show_bug.cgi?id=343251
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Now it works with plasmashell --reverse
>
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/NotificationItem.qml 86b0b6e
>
> Diff: https://git.reviewboard.kde.org/r/122648/diff/
>
>
> Testing
> -------
>
> Tested both --reverse and not --reverse and both look good. See screenshot.
>
>
> File Attachments
> ----------------
>
> --reverse
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/20/5058fe12-ecdd-4345-bcec-4392bbfa78f5__notifications-reverse.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150220/62b8be62/attachment.html>
More information about the Plasma-devel
mailing list