Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76280
-----------------------------------------------------------

Ship it!


Others have pointed out some code issues, I haven't found any more.

As to the approach: +2. If memory serves me well, I implemented the hostip approach lacking a Free solution at that time. I'm happy that Free service now exists, and I'm all for migrating to it. (More so since it's -- again -- broken.)

Thanks for looking into it!

- Sebastian Kügler


On Feb. 18, 2015, 2:37 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
> 
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
> 
> [1] https://location.services.mozilla.com/
> 
> 
> Diffs
> -----
> 
>   dataengines/geolocation/location_ip.h 0a7780c1344c0f48416e524249be6fdada6b9bfd 
>   dataengines/geolocation/location_ip.cpp 1be2acd9478fceafa83896c552e7a3177368b194 
> 
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150219/ab5e8eed/attachment.html>