Review Request 122629: Simplify ToolBox and implement keyboard navigation

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122629/#review76243
-----------------------------------------------------------



toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
<https://git.reviewboard.kde.org/r/122629/#comment52567>

    I don't understand this comment?
    
    if you don't want it to close event.accepted = false to not eat the event.



toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml
<https://git.reviewboard.kde.org/r/122629/#comment52566>

    this doesn't make sense.
    
    Maybe you meant Key_Enter on the second one?


- David Edmundson


On Feb. 18, 2015, 3:17 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122629/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 3:17 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This turns the Column with a Repeater into a ListView by which we will get keyboard and highlight handling for free, also add Accessible to the items.
> 
> 
> Diffs
> -----
> 
>   toolboxes/desktoptoolbox/contents/ui/ActionDelegate.qml 07457c3 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml 8f91fd1 
> 
> Diff: https://git.reviewboard.kde.org/r/122629/diff/
> 
> 
> Testing
> -------
> 
> Using the arrow keys to navigate the menu, Return to trigger an action and Escape to close it; looks like before.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150218/e6341ad6/attachment-0001.html>