Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

[Martin Klapetek]

> On Feb. 18, 2015, 12:33 p.m., Eike Hein wrote:
> > Ship It!
> 
> Martin Klapetek wrote:
>     Can i18n strings be removed in stable?
> 
> Lukáš Tinkl wrote:
>     Sure, removing is fine, it's like B(I)C rules ;)

Ah nice, I thought so but just wanted to make double sure, thanks :)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122622/#review76221
-----------------------------------------------------------


On Feb. 18, 2015, 12:25 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122622/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> If there are no metadata, showing "by Unknown" is a bit strange and serves not much purpose. So let it show only the filename when no metadata available.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/backgroundlistmodel.cpp 346bc8f 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 
> 
> Diff: https://git.reviewboard.kde.org/r/122622/diff/
> 
> 
> Testing
> -------
> 
> Images both with and without metadata works show tooltip as intended.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150218/39f3c4b1/attachment.html>