Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76231
-----------------------------------------------------------



dataengines/geolocation/location_ip.cpp
<https://git.reviewboard.kde.org/r/122628/#comment52554>

    Any idea why we have this magic number?



dataengines/geolocation/location_ip.cpp
<https://git.reviewboard.kde.org/r/122628/#comment52555>

    It could be possible that 'lat' and 'lng' do not exist in the response. Perhaps we should be checking for it.



dataengines/geolocation/location_ip.cpp
<https://git.reviewboard.kde.org/r/122628/#comment52556>

    This is slightly strange.
    
    Normally it's given a double value, but otherwise we give it a string. Why not just not add it?


- Vishesh Handa


On Feb. 18, 2015, 12:52 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 12:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
> 
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
> 
> [1] https://location.services.mozilla.com/
> 
> 
> Diffs
> -----
> 
>   dataengines/geolocation/location_ip.cpp 1be2acd9478fceafa83896c552e7a3177368b194 
> 
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150218/037dff48/attachment.html>