Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla
Martin Gräßlin
mgraesslin at kde.org
Wed Feb 18 12:53:30 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122628/#review76228
-----------------------------------------------------------
dataengines/geolocation/location_ip.cpp
<https://git.reviewboard.kde.org/r/122628/#comment52552>
there's an additional API call to resolve these. If I get enough +1 for the general approach, I'll add support for it.
dataengines/geolocation/location_ip.cpp
<https://git.reviewboard.kde.org/r/122628/#comment52553>
I'll request an API key for KDE if I get enough +1 for the approach.
- Martin Gräßlin
On Feb. 18, 2015, 1:52 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122628/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 1:52 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The service used so far is broken (doesn't resolve latitude and
> longitude). Which means we need to switch the service to unbreak.
>
> This change implements support for the Mozilla Location Service [1].
> Advantages are:
> * free
> * open
> * supports wifi based locationing
> * provided by our FLOSS friends
>
> [1] https://location.services.mozilla.com/
>
>
> Diffs
> -----
>
> dataengines/geolocation/location_ip.cpp 1be2acd9478fceafa83896c552e7a3177368b194
>
> Diff: https://git.reviewboard.kde.org/r/122628/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150218/cc401345/attachment.html>
More information about the Plasma-devel
mailing list