Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip
    Eike Hein 
    hein at kde.org
       
    Wed Feb 18 11:33:38 UTC 2015
    
    
  
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122622/#review76221
-----------------------------------------------------------
Ship it!
Ship It!
- Eike Hein
On Feb. 18, 2015, 11:25 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122622/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 11:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> If there are no metadata, showing "by Unknown" is a bit strange and serves not much purpose. So let it show only the filename when no metadata available.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/backgroundlistmodel.cpp 346bc8f 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 
> 
> Diff: https://git.reviewboard.kde.org/r/122622/diff/
> 
> 
> Testing
> -------
> 
> Images both with and without metadata works show tooltip as intended.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150218/6ea435d5/attachment.html>
    
    
More information about the Plasma-devel
mailing list