Review Request 122592: Align digital clock to full minutes

[Martin Klapetek]

> On Feb. 16, 2015, 4:06 p.m., Martin Klapetek wrote:
> > All I'm getting with this patch is "Error loading QML file: file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9: Cannot assign to non-existent property "intervalAlignment" "
> > 
> > And I've just rebuilt things. Am I missing anything else?
> 
> Bhushan Shah wrote:
>     plasma-framework?

"I've just rebuilt things" included plasma-framework too. But apparently I've rebuilt about 20 minutes before that patch was pushed (I believed it's already in for days) -.-

Nevertheless, with showSeconds the seconds now won't update at all ^_^


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76131
-----------------------------------------------------------


On Feb. 16, 2015, 3:24 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 3:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
>     https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> -------
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150216/cf508e87/attachment.html>