Review Request 122588: [dataengines/mpris2] Use a dedicated component for the media control shortcuts

Kai Uwe Broulik kde at privat.broulik.de
Mon Feb 16 11:03:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122588/#review76113
-----------------------------------------------------------

Ship it!


Ship It!

- Kai Uwe Broulik


On Feb. 16, 2015, 10:34 vorm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122588/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 10:34 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Instead of having the media control shortcuts being grouped under
> "plasmashell" a dedicated component "Media Controller" is added and all
> shortcuts are assigned to it.
> 
> This solves the problem if multiple processes include the dataengine, the
> shortcuts would be registered in each application.
> 
> 
> Diffs
> -----
> 
>   dataengines/mpris2/CMakeLists.txt 3ca83589470b8851e7d51b1f3d2bb3ca3ee436c3 
>   dataengines/mpris2/multiplexer.cpp ab7927d902dfa55b1afaa978e01e5a00f9fca127 
> 
> Diff: https://git.reviewboard.kde.org/r/122588/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> component in global shortcuts configuration
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/51fe906f-58ee-485d-a861-24e886459498__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150216/5b0d2933/attachment.html>


More information about the Plasma-devel mailing list