Review Request 122583: Prevent heading from expanding

Elias Probst mail at eliasprobst.eu
Mon Feb 16 02:28:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122583/#review76093
-----------------------------------------------------------

Ship it!


[Looks way better now](http://i.imgur.com/oncE3Kh.png)!

I wonder whether the widgets could "advertise" a minimum size so that they could be squeezed into a vertical panel - limited by their minimum size.
See [the screenshot](http://i.imgur.com/oncE3Kh.png).
In "Desktop Containment mode" they fit just fine, but in panel mode they seem to advertise a different height and take up way more space.

- Elias Probst


On Feb. 15, 2015, 10:40 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122583/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2015, 10:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 344207
>     https://bugs.kde.org/show_bug.cgi?id=344207
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Just put the heading outside the ColumnLayout to prevent it from ever expanding
> 
> 
> Diffs
> -----
> 
>   applets/systemmonitor/common/contents/ui/Applet.qml 6feda2d 
> 
> Diff: https://git.reviewboard.kde.org/r/122583/diff/
> 
> 
> Testing
> -------
> 
> Works, see screenshots
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150216/7e0a1abd/attachment.html>


More information about the Plasma-devel mailing list