Review Request 122331: Add libinput support to kcm-touchpad

[Martin Gräßlin]

> On Feb. 12, 2015, 1:39 a.m., David Edmundson wrote:
> > Built my X with libinput support.
> > 
> > Without this patch I get an erro, with this I get at least some options, though quite a few seemed disabled as they're just not available in libinput.
> 
> Rajeesh K Nambiar wrote:
>     Indeed, many options are disabled because they are simply not available/exposed by libinput. See the discussion and bug listed here: https://lists.fedoraproject.org/pipermail/devel/2015-January/206918.html
>     To test, just install the libinput Xorg driver (xorg-x11-drv-libinput package in Fedora), it will be preferred over synaptics driver.
> 
> David Edmundson wrote:
>     Yeah, not a lot we can do about that for now.
>     
>     Do you have commit access?
> 
> Rajeesh K Nambiar wrote:
>     I now have the developer account (yay).
>     Will check commit access in the evening once I have access to my system.
> 
> Sebastian Kügler wrote:
>     Why will the libinput driver be prefferred over synaptics if synaptics provides more features and is more mature? Is that a packaging-specific thing, do we have any control over it? From the point of a user, this is going to cause regressions.
> 
> David Edmundson wrote:
>     it's a distro/X thing.
> 
> Rajeesh K Nambiar wrote:
>     X automatically choses libinput driver over synaptics if installed. Users still have the choice to opt out by not installing libinput X driver.
>     Libinput is the common input stack for Wayland and X, and distros (like Fedora) are going to switch to it in next versions. Please also see the rationale at [1] and [2].
>     [1] http://who-t.blogspot.com/2014/09/libinput-common-input-stack-for-wayland.html
>     [2] http://blog.martin-graesslin.com/blog/2014/10/libinput-integration-in-kwinwayland/

> Why will the libinput driver be prefferred over synaptics if synaptics provides more features and is more mature?

because most options provided by the synaptics driver are ridiculous and are not tested at all. Libinput follows the approach of only exposing those options which are non-stupid.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75896
-----------------------------------------------------------


On Feb. 12, 2015, 7:34 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 7:34 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> -------
> 
> ibinput is a library to handle input devices in Wayland compositors and to provide a generic X.Org input driver. Add libinput support to kcm-touchpad.
> Patch authored by Peter Hutterer.
> 
> 
> Diffs
> -----
> 
>   src/kcm/touchpad.kcfg 2afe642 
>   src/kcm/ui/tap.ui 8e081ad 
>   src/touchpadbackend.cpp 93e3dc2 
>   src/backends/x11.cmake f208281 
>   src/backends/x11/libinputproperties.c PRE-CREATION 
>   src/backends/x11/synclientproperties.h 5b32b9f 
>   src/backends/x11/xlibbackend.h 3692a60 
>   src/backends/x11/xlibbackend.cpp 3b5e5be 
>   src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> -------
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
> 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150213/260f55a1/attachment-0001.html>